decompals / decompals/wibo

Buffer overflow detected when used with sjiswrap.exe and compiled with fortify hardening

Open
#70 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
168
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Fortify hardening seems to be causing errors after melee added sjiswrap.exe to the build. I can simply disable the fortify hardening when building wibo, but is this something I should be concerned about?

[1/406] MWCC build/GALE01/src/melee/ft/ft_0877.o
FAILED: build/GALE01/src/melee/ft/ft_0877.o 
/nix/store/9m9p9ip365bs9qdijrckf2r2m5rnsvwc-wibo-0.6.12/bin/wibo /nix/store/chp4xzb09pivg46j8w0y847bl57n18s0-sjiswrap-windows-x86.exe /nix/store/pkh89nzbgbsi2lkx22gvyqhfy3kzgy6x-GC_WII_COMPILERS/GC/1.2.5n/mwcceppc.exe -nowraplines -cwd source -Cpp_exceptions off -proc gekko -fp hardware -align powerpc -fp_contract on -O4,p -enum int -nodefaults -inline auto -pragma "cats off" -pragma "warn_notinlined off" -RTTI off -str reuse -DVERSION=0 -DNDEBUG=1 -maxerrors 0 -nofail -msgstyle gcc -warn off -warn iserror -i src -i src/melee -i src/melee/ft/chara -I- -i src -i src/MSL -i src/Runtime -i build/GALE01/include -i src/dolphin -i src/sysdolphin -MMD -c src/melee/ft/ft_0877.c -o build/GALE01/src/melee/ft && "/nix/store/sxr2igfkwhxbagri49b8krmcqz168sim-python3-3.11.8/bin/python3" tools/transform_dep.py build/GALE01/src/melee/ft/ft_0877.d build/GALE01/src/melee/ft/ft_0877.d
*** buffer overflow detected ***: terminated
Aborted

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported failure using the sjiswrap.exe and wibo command with fortify hardening enabled. Determine whether the abort originates in wibo, sjiswrap.exe, or the hardening configuration, then document a confirmed fix or reproducible limitation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, linux
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.