decocms / decocms/blocks

TanStack migration: Commerce Seo sections in SKIP_RESOLVE_TYPES cause generic page titles

Open
#425 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
2
Avg merge
20h 12m
Merged PRs (30d)
36

Description

Problem

After migrating from Deco Fresh to TanStack Start, PDP and catch-all routes render with generic page titles instead of product-specific SEO metadata.

Root cause: the Commerce Seo block type is listed in SKIP_RESOLVE_TYPES, so the section resolver skips it and returns no data. The page title falls back to a generic default.

Symptoms

  • Product pages show a generic site title instead of the product name.
  • document.title does not change on SPA navigation to PDP routes.
  • og:title and meta description tags are empty or generic.

Fix pattern

Replace the Seo commerce block with a site section that has its own server loader:

  1. Create a site section (e.g. SeoSection) that accepts title and description as CMS props.
  2. Add a loader to the section that returns { title, description } fetched from the product context.
  3. Register the new section in both sections.gen.ts AND section-loaders.ts.
  4. Remove the Commerce Seo block from SKIP_RESOLVE_TYPES or ensure it is resolved via the new section.

Without registering in BOTH files, the section either fails to load or its loader never runs.

Reference

See PR #12 in the site repo for a working implementation of this pattern.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Commerce Seo through SKIP_RESOLVE_TYPES and inspect sections.gen.ts and section-loaders.ts. Compare the working pattern in PR #12, then verify that PDP and catch-all routes resolve title and description data and update document.title, og:title, and meta description on SPA navigation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.