decentralized-identity / decentralized-identity/web5-rs

[Bug] Fix Did Dht Test Vector when 404 / 429 bug is resolved

Open
#286 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Kotlin
Stars
19
Forks
15
PR merge metrics
No merged PRs in 30d

Description

```
// as a replay protection attack if the same did is getting a 404 it will start returning a 429,
// to get around this we just create a new did that is not published to get a 404 for this error code
if(vector_output.did_resolution_metadata.error == "notFound") {
// TODO: According to the did dht spec a 404 should be reutrned when trying to resolve a did that
// does not exists. Currently it reutrns a 429. Uncomment this when resolved - https://github.com/TBD54566975/web5-rs/issues/286
continue

// let private_jwk = Ed25519Generator::generate();
// let identity_key = ed25519::to_public_jwk(&private_jwk);
// let did_dht =
// DidDht::from_identity_key(identity_key.clone()).expect("Should create did:dht");
//
// vector_input = VectorInput{
// did_uri: did_dht.did.uri,
// };
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.