decentralized-identity / decentralized-identity/web5-js

Use the updated `select_credentials` test vector

Open
#512 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
142
Forks
56
PR merge metrics
No merged PRs in 30d

Description

Currently, consuming `select_credentials.json` test vectors in this repo results in failure for the test vectors with these descriptions:
1. `select credentials for presentation, multiple input descriptors, not all of them are satisfied`
2. `select credentials for presentation, using array filter`

We should consider these two things:
1. Is the test vector asserting the correct output?
2. If answer to 1 is yes, is the `selectCredentials()` implementation making incorrect assumptions?
3. Overall, are we interpreting the PEX spec correctly?

The possible outcomes of this issue is that we address the failures by either changing the implementation or changing the test vector.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.