decentralized-identity / decentralized-identity/web5-js

Rename evaluationResults and it will share with the overloaded satisfiesPresentationDefinition

Open
#426 0 comments 0 reactions 1 assignee Claimed by @nitro-neal View on GitHub
package: credentials w3c-vc-dm-2.0
Dominant language
TypeScript
Stars
142
Forks
56
PR merge metrics
No merged PRs in 30d

Description

We will rename evaluationResults and it will share with the overloaded satisfiesPresentationDefinition. This will add more clarity to sdk api surface area.

Changing this:
```js
const evaluationResults = PresentationExchange.evaluatePresentation({ presentationDefinition, presentation })
```

to this:

```js
type WithPresentationDefinition = {
vcJwts: string[];
presentationDefinition: PresentationDefinitionV2;
};

type WithPresentationSubmission = {
presentationSubmission: PresentationSubmission;
presentationDefinition: PresentationDefinitionV2;
};

type SatisfiesPresentationOptions = WithPresentationDefinition | WithPresentationSubmission;

const result: ValidationResult = PresentationExchange.satisfiesPresentationDefinition({ options: SatisfiesPresentationOptions })
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.