decentralized-identity / decentralized-identity/wallet-rendering

URI format doesn't work with newer `ajv` lib

Open
#28 3 comments 1 reaction 1 assignee Claimed by @bumblefudge View on GitHub
editorial v1
Dominant language
JavaScript
Stars
8
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Expected: upgrade libs and all tests pass
Actual: Entity schema tests fails with URI format. AJV was anchored on the test suite at 6.12.5. Upgrade breaks the test.

```
Valid Entity Schema Test:
Error: unknown format "uri" ignored in schema at path "#/definitions/image/properties/uri"
```
Recent AJV lib 8.12.0 does not permit uri as schema format, and test will fail.

```
- "ajv": "^8.12.0",
+ "ajv": "^6.12.5",
```

Suggested fixes:

- Reformat format path as regex, so preformat rules aren't a problem.
- Possibly an issue with ajv implementation. Might have updated to need to use https://github.com/ajv-validator/ajv-formats
- Check if JSONSchema spec actually updated directly, such that it doesn't support `uri` format anymore.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.