decentralized-identity / decentralized-identity/sidetree-reference-impl

Consider removing the commit-reveal checks in `OperationProcessor`.

Open
#29 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
4
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Technically, the commit-reveal checks is already performed by `Resolver` because it builds the commit-reveal lookup map, so the commit-reveal checks in `OperationProcessor` is current redundant.

One could make a case to remove these checks in `OperationProcessor` from the performance standpoint. One could also make a case to keep it from the design standpoint that `OperationProcessor` should not know the implementation details of the `Resolver`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.