decentraland / decentraland/unity-explorer
[TECH DEBT] Chat | USE PKCS7
- Dominant language
- C#
- Stars
- 23
- Forks
- 17
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 101
Description
### π **Priority Level:**
Low
### π **Area/Component:**
`Chat\History\ChatHistoryEncryptor.cs`
### π **Description:**
Unresolved TODO comment in the codebase:
> TODO: USE PKCS7
### π **Current State:**
The following line is present in `Chat\History\ChatHistoryEncryptor.cs`:
```csharp
cryptoProvider.Padding = PaddingMode.Zeros; // TODO: USE PKCS7
```
### π‘ **Proposed Solution:**
Address the TODO as described in the comment, or remove it if no longer relevant.
### βοΈ **Impact Assessment:**
#### Performance Impact:
To be assessed when the TODO is picked up.
#### Maintainability Impact:
Unresolved TODOs accumulate as tech debt and obscure the intended final state of the code.
#### Risk of Refactoring:
Low β scoped to the referenced location.
### π **Effort Estimate:**
XS
### π **Dependencies:**
N/A
### π₯οΈ **Additional Notes:**
Created automatically from a bulk TODO audit (todo-list.txt entry #27).
Contributor guide
Research direction
Read Chat\History\ChatHistoryEncryptor.cs at the PaddingMode.Zeros assignment and inspect the surrounding encryption setup to understand the TODO's intent. Confirm whether PKCS7 should replace the current padding or whether the TODO is obsolete, then validate the resulting chat-history encryption behavior with the project's relevant checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100