decentraland / decentraland/unity-explorer

[TECH DEBT] AvatarRendering | must check if the wearable is no longer in the cache, otherwise ref count leaks

Open
#9,129 2 comments 0 reactions 0 assignees View on GitHub
3-low memory-issue refactor stale tech debt
Dominant language
C#
Stars
23
Forks
17
Avg merge
2d 16h
Merged PRs (30d)
101

Description

### πŸ“Š **Priority Level:**
Low

### πŸ“ **Area/Component:**
`AvatarRendering\Thumbnails\Systems\ResolveAvatarAttachmentThumbnailSystem.cs`

### πŸ“ **Description:**
Unresolved TODO comment in the codebase:

> TODO must check if the wearable is no longer in the cache, otherwise ref count leaks

### πŸ” **Current State:**
The following line is present in `AvatarRendering\Thumbnails\Systems\ResolveAvatarAttachmentThumbnailSystem.cs`:

```csharp
/// TODO must check if the wearable is no longer in the cache, otherwise ref count leaks
```

### πŸ’‘ **Proposed Solution:**
Address the TODO as described in the comment, or remove it if no longer relevant.

### βš–οΈ **Impact Assessment:**
#### Performance Impact:
To be assessed when the TODO is picked up.

#### Maintainability Impact:
Unresolved TODOs accumulate as tech debt and obscure the intended final state of the code.

#### Risk of Refactoring:
Low β€” scoped to the referenced location.

### πŸ“ˆ **Effort Estimate:**
XS

### πŸ”— **Dependencies:**
N/A

### πŸ–₯️ **Additional Notes:**
Created automatically from a bulk TODO audit (todo-list.txt entry #6).

Contributor guide

Open the contributing guide

Research direction

Start in AvatarRendering\Thumbnails\Systems\ResolveAvatarAttachmentThumbnailSystem.cs at the TODO and trace how wearables enter and leave the cache and how reference counts are updated. Confirm the behavior when a wearable is no longer cached, then verify that the reference count no longer leaks and remove the TODO once the behavior is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.