decentraland / decentraland/ui2

No Modal/ModalNavigation primitives — buy/authorization flows stuck on semantic-ui

Open
#477 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
0
Forks
2
Avg merge
2h 1m
Merged PRs (30d)
10

Description

The marketplace buy flow spans three visual systems: newer chrome, legacy `decentraland-ui` semantic modals (`BuyWithCryptoModal` and friends), and decentraland-dapps' `AuthorizationModal` (also semantic-ui). ui2 has no Modal/ModalNavigation primitives at all — the marketplace imports ui2 only for narrow inline controls (`CreditsToggle`, `WearablePreview`, toggles) — so there is nothing to migrate those modals to, and the style break users report in the purchase/authorization flow can't be fixed downstream first.

Suggested sequence, each step publishable independently:
1. ui2 `Modal` + `ModalNavigation` primitives.
2. Port decentraland-dapps' `withAuthorizedAction`/`AuthorizationModal` onto them.
3. Migrate marketplace buy-flow modals.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.