decentraland / decentraland/ui2
CatalogRarityChip still derives from the stale schemas palette (follow-up to #475)
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 2
- Avg merge
- 2h 1m
- Merged PRs (30d)
- 10
Description
PR #475475 moved `CatalogCard`'s image background to `theme.palette.rarities` (the current Figma palette, matching `RarityBadge`). The `subduedRarity` chip variant (`CatalogRarityChip` in `CatalogCard.styled.ts`) still derives its surface/text from `@dcl/schemas` `Rarity.getColor`/`getGradient` — so that variant now blends two palettes on one card.
Its comment also asserts the schemas palette is the source of truth, directly contradicting CLAUDE.md §6 (which names `theme.palette.rarities` as the reference pattern). Fix: derive the chip from `theme.palette.rarities` + `theme.palette.raritiesText` and update the comment.
Bigger question (needs design input): whether `@dcl/schemas` `Rarity.COLORS` — unchanged since 2021 — should be repainted to the current Figma hexes for all downstream consumers. That's a visual-regression risk across marketplace/explorer surfaces, so it should be decided deliberately, not patched.
Contributor guide
Research direction
Start in CatalogCard.styled.ts at the subduedRarity variant, then read CLAUDE.md §6 and compare the existing CatalogCard and RarityBadge palette usage. Update the chip's surface/text derivation and comment so it follows theme.palette.rarities and theme.palette.raritiesText; leave the broader @dcl/schemas repaint question undecided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100