decentraland / decentraland/marketplace

[Bug] Home Carousel mixing Items and NFTs

Open
#2,245 0 comments 0 reactions 1 assignee Claimed by @juanmahidalgo View on GitHub
tech enhancement
Dominant language
TypeScript
Stars
1.2k
Forks
690
Avg merge
1d 5h
Merged PRs (30d)
23

Description

## 🎉 Description

The `Newest Items` carousel from the Home Page, sometimes is mixing up Items and NFTs, where it should only show Items.

* [X] 🐛 This is a bug report.
* [ ] 📈 This is a feature request.

## 📝 Details

This is due to the selector that puts together the home page carousel content, has a random logic of looking for the `id` (either item_id or nft_id) in the `nftsById` or `itemsById` map, not knowing if the id belongs to an item or nft, so if they collide (in this case they do), it will prioritize it as nft

E.g: The emote here in the first slot of the carousel is an NFT that has the same id of an item (pure coincide)

![image](https://github.com/decentraland/marketplace/assets/8763687/98ab2cb5-7419-4795-b01a-8e67cf92745d)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.