decentraland / decentraland/decentraland-dapps

Stop ignoring event errors on WalletProvider

Open
#137 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
116
Forks
52
Avg merge
18h 12m
Merged PRs (30d)
11

Description

Even tho the try catch [here](https://github.com/decentraland/decentraland-dapps/blob/master/src/providers/WalletProvider/WalletProvider.ts#L21) or [here](https://github.com/decentraland/decentraland-dapps/blob/master/src/providers/WalletProvider/WalletProvider.ts#L55) is there to provide a way to safeguard against old providers, it was eating other errors like decentraland-connect's inability to handle .on() methods.

We maybe should remove the more generic `handle()` method and try to do it case-by-case

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.