decentraland / decentraland/catalyst

[Memo] All signed stuff should be timestamped

Open
#33 0 comments 0 reactions 0 assignees View on GitHub
security
Dominant language
TypeScript
Stars
52
Forks
56
Avg merge
5m
Merged PRs (30d)
1

Description

Not just ephemerals, but entities as well. Otherwise, one can do replay attacks!

I was reading through:

https://github.com/decentraland/katalyst/blob/dc2cb5fcdf21df34f639aac0b295a28232f19205/crypto/src/Authenticator.ts#L79

I think in this case it's fine because all Entities have a timestamp. But I wanted to leave this issue open as a reminder.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.