decentraland / decentraland/builder

Add support to use a particular branch of the SDK for QA testing purposes

Open
#3,092 0 comments 0 reactions 0 assignees View on GitHub
:watermelon: dapps tech enhancement
Dominant language
TypeScript
Stars
156
Forks
91
Avg merge
2d 7h
Merged PRs (30d)
31

Description

## 🎉 Description

Add a query param to load the SDK from a specific branch/PR so QA can test the branch in the context of the Builder, which allows them to test more use cases and catch integration issues earlier.

* [ ] 🐛 This is a bug report.
* [x] 📈 This is a feature request.

## 📝 Details

The `@dcl/inspector` is a static webapp served from the Builder's own assets, but when a PR is created in the SDK repo, a preview is always deployed to cloudflare pages. So technically we could pass a query param, like `?sdk-branch=fix/something` telling the Builder to load the assets of the editor from a particular PR, get the CF pages url, and use that instead of the local url.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.