decentraland / decentraland/builder

Hide 'Add Existing Item' option if there are no valid items to add

Open
#2,490 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
156
Forks
91
Avg merge
2d 7h
Merged PRs (30d)
31

Description

## πŸŽ‰ Description

* [ ] πŸ› This is a bug report.
* [x] πŸ“ˆ This is a feature request.

## πŸ“ Details

We may hide the Add existing item option if there are no items in the collection, same with the items tab.

![image.png](https://images.zenhubusercontent.com/636115f91bf3a9253642c51e/1da67db2-36e5-4211-9261-6f790b1d2002)
![image.png](https://images.zenhubusercontent.com/636115f91bf3a9253642c51e/c8b6cd81-8113-426d-a72e-a8c8d68e867c)

## πŸ”’ Steps To Reproduce Issue [ Good To Have ]

```
- Go to the Collections tab
- Open a collection
- Try to add an existing item
```

If it opens a new modal with the message "No valid items found", should we hide the option in the dropdown in the first place?

Contributor guide

Open the contributing guide

Research direction

Start in the Collections tab by reproducing the flow of opening a collection and choosing Add existing item. Trace the dropdown and the "No valid items found" modal; done means the option is hidden when no valid items can be added and remains available when valid items exist.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.