decentraland / decentraland/builder

Use the builder client to fetch the approval data

Open
#1,855 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
TypeScript
Stars
156
Forks
91
Avg merge
2d 7h
Merged PRs (30d)
31

Description

The `handleInitiateTPItemsApprovalFlow` should use the builder-client instead of directly fetching that from the builder server.
For this we need to:
- [ ] Update the builder client so it can fetch approval data for a collection
- [ ] Release it and update the dependency here
- [ ] Update the saga on `collection/sagas.ts` to use the new builder client version
- [ ] Remove the unused builder.ts method

We might need an issue to track this on the builder-client side of things. We can just reference this issue for now

Contributor guide

Open the contributing guide

Research direction

Start with handleInitiateTPItemsApprovalFlow in collection/sagas.ts and inspect the existing builder.ts method that fetches approval data. Check the builder-client changes and dependency release needed for collection support, then update the saga and remove the unused method; done means the saga uses the released builder client for collection approval data.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.