decentraland / decentraland/builder

Save assets pack not computing the progress correctly

Open
#1,792 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
156
Forks
91
Avg merge
2d 7h
Merged PRs (30d)
31

Description

The [function in charge of updating the progress of saving the assets](https://github.com/decentraland/builder/blob/1b7e26d6d889eaa1aaf21fa7197477a43106af8f/src/modules/assetPack/sagas.ts#L31) is executed once and then, [its result](https://github.com/decentraland/builder/blob/1b7e26d6d889eaa1aaf21fa7197477a43106af8f/src/modules/assetPack/sagas.ts#L74) is used as a function to be executed [after an asset it loaded](https://github.com/decentraland/builder/blob/1b7e26d6d889eaa1aaf21fa7197477a43106af8f/src/modules/assetPack/sagas.ts#L75). As the function is executed with the total values of items once, executing it again as a promise won't work.

Fix this procedure to make the progress be updated as it should be.

Contributor guide

Open the contributing guide

Research direction

Start in src/modules/assetPack/sagas.ts at the progress updater around lines 31, 74, and 75. Trace how the updater result is passed after each asset is loaded, then verify that progress is recalculated and updated for each asset rather than computed only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.