decentraland / decentraland/builder

Refactor the actions to delete an item and a collection to use the loading states of the request

Open
#1,484 0 comments 0 reactions 2 assignees Claimed by @LautaroPetaccio View on GitHub
Dominant language
TypeScript
Stars
156
Forks
91
Avg merge
2d 7h
Merged PRs (30d)
31

Description

The `deleteItemRequest` action and `deleteCollectionRequest` are used in several components such as `Header`, `CollectionCard`, `CollectionMenu`, `ItemDetailPage`, `RightPanel`, etc in such a way that the process of the deletion of the item or the collection isn't waited or taken into consideration. If the builder server takes a long time to delete the item or the collection, the experience will not be the expected one, taking into consideration that the item will still remain active until the request to delete it gets completed.

To fix this, an analysis on how it's used on all the components must be done to take into consideration how each component should react upon waiting for the request to be completed and a possible failure of it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.