decentraland / decentraland/asset-bundle-converter

Remove dead lowerCaseHashes rename logic in CleanAssetBundleFolder

Open
#270 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
4
Forks
8
Avg merge
26m
Merged PRs (30d)
1

Description

## Context

`CleanAssetBundleFolder` in `Utils.cs` renames output bundle files from lowercase to proper-cased hashes using the `lowerCaseHashes` dictionary. This was needed when content hashes could have mixed case.

All Decentraland content hashes are bafkrei CIDs (base32-lowercase) — the rename is always a no-op.

## Cleanup

- Remove `lowerCaseHashes` field and `PopulateLowercaseMappings` from `AssetBundleConverter.cs`
- Remove the `lowerToUpperDictionary` parameter from `CleanAssetBundleFolder` in `Utils.cs`
- Update `IDirectory.CleanAssetBundleFolder` and its implementation to drop the dictionary parameter
- Remove the file rename logic (lines 546-551 in `Utils.cs`) — just delete the `.manifest` files

## References

Follow-up from PR #269.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.