decaporg / decaporg/decap-cms

Merging a PR to a protected branch with approvers does not update the netlify-cms workflow

Open
#1,592 2 comments 1 reaction 0 assignees View on GitHub
pinned
Dominant language
JavaScript
Stars
19.4k
Forks
3.1k
Avg merge
1d 14h
Merged PRs (30d)
9

Description

**- Do you want to request a *feature* or report a *bug*?**
bug

**- What is the current behavior?**
If the publish branch is a protected branch on GitHub with required reviews enabled, and you subsequently approve and merge the pull request in the GitHub GUI or CLI, the content remains in 'Ready to publish' section of the workflow.

**- If the current behavior is a bug, please provide the steps to reproduce.**
Set up a netlify-cms static site with GitHub backend, protect the master branch and create some content in netlify-cms to trigger a PR. Approve and merge the PR within github. Return to netlify-cms under the 'workflow' tab, the content is still in the column it was in on creating the PR, and doesn't look like it has been published, even though it has been merged to master.

**- What is the expected behavior?**
Whether the PR is merged in netlify-cms or GitHub GUI/CLI the content should not remain in the workflow

**- Please mention your versions where applicable.**

Netlify CMS version: 2.0.9

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.