[ansible_plugins] Handling is broken with collections support

Hey @all,

we are currently using debops via git submodule integration and would like to keep it that way. This broke for us with the recent changes to support ansible collections. As for now we were able to distinguish between our roles and the debops roles by setting the roles_path accordingly and referencing them via their folder names.

I found that, I could setup a structure simulating a fake collection like that:

ansible.cfg
extern
     |
     - ansible-debops (git  submodule ansible-debops.git)
     - collections
         |
         -  ansible_collections
                |
                - debops
                       |
                       - debobs (link to ../../../ansible-debops/ansible/)

If I set collections_paths in ansible.cfg to ./extern/collections, I just have to rename the role imports in our playbooks to use the FQCN (debops.python => debops.debops.python).

This works for all roles but debops.ansible_pluginsand all the debops_contrib.* roles.

The offending line appears to be:
ERROR! the role 'debops.debops.debops-contrib.apparmor' was not found in ...
- import_role:
    name: debops.debops.debops-contrib.apparmor
          ^ here

I suggest to rename debops.ansible_plugins to ansible_plugins or to remove it completely and relay on plugins directory on collections level.

If you like release contrib roles in a different collection please separat them into a different directory or name them collections compliant like contrib_*.

Of course I could write a shell script linking all roles to their corresponding debops.* names and continue with the include via roles_path. But I do not like this solution :).

Any help or ideas are appreciated.

Start by reproducing the collection layout described in ansible.cfg, including the linked ansible-debops directory and ansible_collections tree. Compare handling of ansible_plugins and debops_contrib roles with the roles that already work through FQCN imports. Done means these roles work with the git-submodule collection setup without requiring generated links or a roles_path workaround.