debezium / debezium/dbz

Remainder review comments on Ingres Connector initial code drop

Open
#1,705 0 comments 0 reactions 0 assignees View on GitHub
component/ingres-connector type/task
Dominant language
HTML
Stars
6
Forks
8
Avg merge
2d 19h
Merged PRs (30d)
1

Description

Per request when we merged https://github.com/debezium/debezium-connector-ingres/pull/3#top, here are the remaining review comments to explore and resolve

1. https://github.com/debezium/debezium-connector-ingres/pull/3#discussion_r2698537645 Here it's mentioned that there is a much larger list of options to pull from. Is there a list to reference? Informix has a couple added options, not all of them looked applicable to Ingres.
2. https://github.com/debezium/debezium-connector-ingres/pull/3#discussion_r2708073188 A question of do we need to handle RELATION records. After looking into this, yes, Ingres should be able to send them mid-transaction so that needs to be addressed.
3. https://github.com/debezium/debezium-connector-ingres/pull/3#discussion_r2708087517 asking about the cache comment. Ingres does work as Informix works, so we have to cache records until the end of the transaction.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.