debezium / debezium/dbz

[Debezium Operator Helm chart] Conflicting `app.kubernetes.io/managed-by` label

Open
#1,673 9 comments 0 reactions 0 assignees View on GitHub
type/bug
Dominant language
HTML
Stars
6
Forks
8
Avg merge
2d 19h
Merged PRs (30d)
1

Description

`debezium-operator` helm charts hardcodes label `app.kubernetes.io/managed-by: quarkus` to resources deployed by chart.

It's problematic, as it goes against Helm best practices. https://docs.helm.sh/docs/chart_best_practices/labels/#standard-labels. It's expected for label `app.kubernetes.io/managed-by` to be set as `{{ .Release.Service }}`. Or just `Helm` if you intend to hardcode it, as this is what effectively a result of rendering the templates. Or just drop it, `helm install` can add it automatically.

With custom label value we see probalematic behaviour when kustomizing and diffing the chart, somewhere during the pipeline expected label `app.kubernetes.io/managed-by: Helm` appears and this triggers a perpetual diff between planned and actual state of labels.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.