dcramer / dcramer/peated

Handle renamed distilleries/brands

Open
#207 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
103
Forks
18
Avg merge
1h 19m
Merged PRs (30d)
555

Description

They should probably be the same entity in the database, but it creaets a problem.

Kinsip used to be Gilead 66. The whisky used to be bottled under Gilead 66. We can't force those bottle names to be Kinsip now, and we'd prefer to not use two entities, though maybe thats ok?

We at the very least need links between entities. This would be useful for Mars too (e.g. Mars owns Shinshu, which was renamed...).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the database model for distilleries and brands and reviewing how existing entities are represented. Compare the Kinsip/Gilead 66 and Mars/Shinshu cases, then clarify whether the intended result is merged entities or explicit links before defining what completion means.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, database
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.