dcramer / dcramer/peated

Improve image modal with additional behaviors

Open
#149 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
103
Forks
18
Avg merge
1h 19m
Merged PRs (30d)
555

Description

The image modal leaves a lot to desired. It lets you (almost) zoom in on an image, though its not compatible with pinch to zoom which can be annoying.

We should make the modal be more than simply an image zoom, and include some details about the tasting and some obvious controls. This is particularly relevant on mobile where the concept of the image modal is less obvious.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by locating the image modal implementation and reviewing its current zoom behavior, then determine how tasting details, visible controls, and pinch-to-zoom should work on mobile. Done should include the requested modal behaviors and a clear way to verify them.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, mobile-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.