dbt-labs / dbt-labs/dbt

[CT-3488] [Feature] Generate manifest at build time or in PR

Open
#9,272 6 comments 0 reactions 0 assignees View on GitHub
awaiting_response engine:v1 type:feature
Dominant language
Rust
Stars
13.8k
Forks
2.6k
Avg merge
21h 31m
Merged PRs (30d)
56

Description

### Is this your first time submitting a feature request?

- [X] I have read the [expectations for open source contributors](https://docs.getdbt.com/docs/contributing/oss-expectations)
- [X] I have searched the existing issues, and I could not find an existing issue for this feature
- [X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

### Describe the feature

Currently dbt-core relies on a delicate mechanism to generate a manifest: https://github.com/dbt-labs/dbt-core/blame/6e0a38720529360d061bd4e24e140f5ec55f8c15/tests/functional/artifacts/test_previous_version_state.py#L414

Instead of relying on commenting/uncommenting out test code we should generate this as part of our CI process either on the PR or in the release.

The current setup risks us to accidentally merge a manifest change: https://github.com/dbt-labs/dbt-core/pull/9195#discussion_r1423169447 and is unintuitive for core development

### Describe alternatives you've considered

_No response_

### Who will this benefit?

_No response_

### Are you interested in contributing this feature?

_No response_

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.