dbt-labs / dbt-labs/dbt

[CT-1847] Move `MP_CONTEXT` somewhere else.

Open
#6,647 2 comments 0 reactions 0 assignees View on GitHub
engine:v1 type:tech-debt
Dominant language
Rust
Stars
13.8k
Forks
2.6k
Avg merge
21h 31m
Merged PRs (30d)
56

Description

### Describe the feature

Discovered during BLG for #6509 --

`MP_CONTEXT`, a mutex used for multi-processing, is currently stored in `flags`. This is not the right place to put that as it's definitively not a flag. Additionally, with the combining of `flags` and `args` in the api-ficiation work, we can no longer serialize flags as JSON because of `MP_CONTEXT`.

@ChenyuLInx Fixed this by removing `MP_CONTEXT` from flags before serialization, however it would be better to find it a proper place to live instead of hitching a ride on flags.

This ticket represents the work needed to remove `MP_CONTEXT` from flags and put it somewhere more appropriate.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.