dbt-labs / dbt-labs/dbt

[Feature] Add tests for installing local package when symlinks are not supported by the OS

Open
#10,796 0 comments 1 reaction 0 assignees View on GitHub
engine:v1 type:feature type:tech-debt
Dominant language
Rust
Stars
13.8k
Forks
2.6k
Avg merge
21h 31m
Merged PRs (30d)
56

Description

### Housekeeping

- [X] I am a maintainer of dbt-core

### Short description

We are not currently testing the case where the user's operating system (OS) doesn't support symlinks. As a result, we could accidentally break these code paths in the future.

So we'd like to add functional tests for scenarios like https://github.com/dbt-labs/dbt-core/issues/9719 _specifically_ when the OS running dbt does not support symlinks.

Create a `packages.yml` file:
```yaml
packages:
- local: ../
```

Then install it:

```shell
dbt deps
```

### Acceptance criteria

There are functional tests that cover the code paths when a user's operating system doesn't support symlinks (which is used for [local package dependencies](https://docs.getdbt.com/docs/build/packages#local-packages) when running `dbt deps`).

### Suggested Tests

We don't know how exactly to test it currently, so this would be something to brainstorm and choose an approach.

### Impact to Other Teams

None.

### Will backports be required?

It would probably be wise to backport to supported versions of dbt-core to avoid accidentally missing regressions when merging _other_ backports!

### Context

This was discovered during review of https://github.com/dbt-labs/dbt-core/pull/9734.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.