dbt-labs / dbt-labs/dbt

Build and check source distributions and wheels independently in build packages

Open
#10,465 1 comment 0 reactions 0 assignees View on GitHub
engine:v1 type:tech-debt
Dominant language
Rust
Stars
13.8k
Forks
2.6k
Avg merge
21h 31m
Merged PRs (30d)
56

Description

### Housekeeping

- [X] I am a maintainer of dbt-core

### Short description

* dbt-core has overlaps in its build dependencies and functional ones (e.g. `packages`)
* setuptools 71+ no longer vends its dependencies and will rely on dependencies installed in the system
* this means the wheel install could change the python dependencies before source distribution install and validation
* we've fixed this by swapping the order in 1.3 and below (since the `packages` conflict only arose there), but a better long term fix would be to build and check wheels and source dists in separate venvs to avoid package conflicts

### Acceptance criteria

build and check wheels and source dists in separate venvs to avoid package conflicts in the build packages step of workflows/main.yml

### Suggested Tests

n/a

### Impact to Other Teams

n/a

### Will backports be required?

yes, back to and including 1.4

### Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.