dbt-labs / dbt-labs/dbt-jsonschema

`dbt_project.yaml` allows additional properties in `flags`, which can overlook typos in flag names

Open
#179 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
169
Forks
61
Avg merge
1m
Merged PRs (30d)
1

Description

The [latest schema for dbt_project.yaml](https://github.com/dbt-labs/dbt-jsonschema/blob/1dfd5cb547015a82f8357b6757af7807c4e3b301/schemas/latest/dbt_project-latest.json#L64) doesn't have `additionalProperties: false` set for its top-level `flags` key. This means that if you make a typo on a flag name, your `dbt_project.yaml` will still pass JSON schema validation. Ask me how I know 😅

I'm happy to open a PR to fix this, but wanted to make sure that it's not intentional first, since `additionalProperties: false` is being used elsewhere in that schema.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.