dbt-labs / dbt-labs/dbt-adapters

[Unit Testing] Extend TestRedshiftUnitTestingTypes to include complex types

Open
#638 1 comment 0 reactions 0 assignees View on GitHub
feature:unit-tests pkg:dbt-redshift type:enhancement
Dominant language
Python
Stars
233
Forks
362
Avg merge
3d 22h
Merged PRs (30d)
9

Description

### Is this your first time submitting a feature request?

- [X] I have read the [expectations for open source contributors](https://docs.getdbt.com/docs/contributing/oss-expectations)
- [X] I have searched the existing issues, and I could not find an existing issue for this feature
- [X] I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

### Describe the feature

Per https://github.com/dbt-labs/dbt-core/issues/8423#issuecomment-1968059902, add redshift-specific input fixtures extend [`TestRedshiftUnitTestingTypes`](https://github.com/dbt-labs/dbt-redshift/blob/248928065bd01e8457a9e47f0705cf98b8a5b055/tests/functional/adapter/unit_testing/test_unit_testing.py#L7) to test complex types (at least json & arrays / `SUPER`). Arrays have already been [mocked out](https://github.com/dbt-labs/dbt-redshift/blob/248928065bd01e8457a9e47f0705cf98b8a5b055/tests/functional/adapter/unit_testing/test_unit_testing.py#L25-L33) in the existing test.

### Describe alternatives you've considered

n/a

### Who will this benefit?

dbt users of dbt-redshift using unit testing

### Are you interested in contributing this feature?

### Anything else?

Depends on https://github.com/dbt-labs/dbt-adapters/issues/113.

See [dbt-bigquery](https://github.com/dbt-labs/dbt-bigquery/blob/dd300f9c5d13dce9628ad6cacc8403118c44fd01/tests/functional/adapter/unit_testing/test_unit_testing.py#L7) for a similar example.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.