dbt-labs / dbt-labs/dbt-adapters

[ADAP-478] Remove Databricks specific tests

Open
#502 0 comments 0 reactions 0 assignees View on GitHub
pkg:dbt-spark type:task
Dominant language
Python
Stars
233
Forks
362
Avg merge
3d 22h
Merged PRs (30d)
9

Description

### High Level Task
Remove the Databricks profiles from `dbt-spark` integration tests.

### Acceptance Criteria
- [ ] Profiles for `databricks_sql_endpoint`, `databricks_sql_endpoint` and `databricks_http_cluster` are removed from codebase
- [ ] All decorators are updated to reflect the removal of above profiles
- [ ] All tests that should be removed are fully removed

### Details
This is a bit complex since tests are tagged to be skipped, not to be run. The tests that need to be fully removed are the ones that have the following decorator:

```python
@pytest.mark.skip_profile("spark_session", "apache_spark")
```

If the decorator contains `databricks_sql_endpoint`, `databricks_sql_endpoint` or `databricks_http_cluster` the decorator just need to be modified.

[conftest.py](https://github.com/dbt-labs/dbt-spark/blob/main/tests/conftest.py) also needs to be modified to remove the databricks profiles.

### Additional Notes
Since we will be removing the Databricks profiles in the GitHub Action, this will be dead code but the tests will continue to work.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.