dbt-labs / dbt-labs/dbt-adapters

[Tech debt] We need to ensure that `dbt-athena` and `dbt-athena-community` always match in version

Open
#412 0 comments 0 reactions 0 assignees View on GitHub
pkg:dbt-athena type:task
Dominant language
Python
Stars
233
Forks
362
Avg merge
3d 22h
Merged PRs (30d)
9

Description

### Is this your first time submitting an issue in dbt-athena?

- [X] I have searched the existing issues, and I could not find an existing issue for this feature

### Describe your request/question

We want `dbt-athena-community` to be the same package as `dbt-athena` for every version, down to the patch/pre-release/etc. There is no easy way to enforce this since we can't point one package to another package's version file (seemingly a `hatch` or `setuptools` limitation). And we certainly can't have calculated versions in the build dependencies in `dbt-athena-community`. The next best thing is to add a `pre-commit` check that ensures the versions are all set to the same thing. This includes:

- `dbt-athena/dbt/athena/__version__.py::version`
- `dbt-athena-community/pyproject.toml::project.version`
- `dbt-athena-community/pyproject.toml::project.dependencies.dbt-athena`

We are comfortable bumping the version manually for now as this overlap is a temporary solution for providing backwards compatibility as `dbt-athena-community` users migrate to `dbt-athena`.

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.