dbt-labs / dbt-labs/actions

[CT-2437] [Bug] Fix when the release test branch gets bumped

Open
#92 0 comments 0 reactions 1 assignee Claimed by @mikealfare View on GitHub
bug tech_debt
Dominant language
Python
Stars
16
Forks
7
Avg merge
2d 19h
Merged PRs (30d)
2

Description

### Current State
The `*.latest` branch gets cut when we are ready to release the first `rc` with the [cut-release-branch.yml](https://github.com/dbt-labs/actions/blob/main/.github/workflows/cut-release-branch.yml) action. Currently, this action also bumps the branch to test releases off [here](https://github.com/dbt-labs/actions/blob/4a9bc4a86549ced8afb9b1cdca6aedb64f38154c/.github/workflows/cut-release-branch.yml#L138-L154).

### Problem
The problem is that an `rc` is not a final release so when the nightly adapter release tests runs, it cannot find the correct version of core and fails.

### Possible Solutions
This is a first pass and definitely needs more thought.

1. Completely remove the [step to bump this](https://github.com/dbt-labs/actions/blob/4a9bc4a86549ced8afb9b1cdca6aedb64f38154c/.github/workflows/cut-release-branch.yml#L138-L154) and do it manually. Not ideal because we will forget.
2. Somehow make the action smart enough to figure out what the `latest` is and programmatically determine what branch we should run off. More ideal but I'm not sure how complex this would be.
3. Remove bumping the latest from [cut-release-branch.yml](https://github.com/dbt-labs/actions/blob/main/.github/workflows/cut-release-branch.yml) and do it as part of the release when we're doing the first final release. This seems a bit unintuitive that it will happen.
4. Allow the release-test to use pre-release versions. Will involve figuring out why [this step](https://github.com/dbt-labs/dbt-core/blob/ada8860e48b32ac712d92e8b0977b2c3c9749981/.github/workflows/nightly-release.yml#L58-L62) doesn't return the pre-release with the version. _Most ideal_

### Additional Information

`dbt-core` runs against `main` so this is not an issue for that repo. This only affects the adapters. Each adapter has a custom [update_release_branch.sh](https://github.com/dbt-labs/dbt-snowflake/blob/main/.github/scripts/update_release_branch.sh) script.

`dbt-spark` does not currently have a release test

`dbt-bigquery` did not get this bumped and therefore did not break. But that also means it never gets bumped automatically and must be done manually.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.