dblock / dblock/slack-sup2

Reconsider sup "next week" vs. "in a week"

Open
#37 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Ruby
Stars
6
Forks
1
Avg merge
9m
Merged PRs (30d)
4

Description

A team had a sup on 4/10, a Friday, then set sup day to Thursday and interval of a week.

On Thursday 4/16 there was no sup because it hasn't been a week. But it's next week and after the previous round was closed/reminded at (on 4/13).

Should it have had a sup that Thursday 4/16?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the scheduling check in slack-sup/models/team.rb at line 141 and trace how the previous round's 4/13 closure or reminder affects the 4/16 decision. Reproduce the 4/10 Friday, Thursday schedule, and one-week interval scenario, then confirm the intended behavior before adding coverage for the agreed interpretation.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.