dbeaver / dbeaver/dbeaver

Syntax highlighting of comment blocks occasionally fails

Open
#12,861 4 comments 0 reactions 1 assignee Claimed by @ShadelessFox View on GitHub
x:postgresql xf:sql xf:sql parser xf:ui
Dominant language
Java
Stars
51.8k
Forks
4.4k
Avg merge
3d 8h
Merged PRs (30d)
188

Description

#### System information:
- Kubuntu 20.04
- DBeaver 21.1
- Additional extensions

#### Connection specification:
- Database name and version: PostgreSQL v12
- Driver name: PostgreSQL
- Do you use tunnels or proxies (SSH, SOCKS, etc)? No

#### Describe the problem you're observing:

I observed that recently (since several months ago) syntax highlighting of comment blocks fails, renders part of comment as a code. It also leads to render true code which follows mentioned comment as a comment. See in example below, BEGIN word is highlighted as a comment.

#### Steps to reproduce, if exist:

Here is example of code which is breaks syntax highlighting. It's the beginning of function code.

```
CREATE OR REPLACE FUNCTION sql_queues.push(_queue character varying, _query character varying)
RETURNS void
LANGUAGE plpgsql
AS $function$/*DOCU
Inserts data to SQL Queue

### IN params:
* `_queue` VARCHAR, queue name, Ussually table name without 'q_' prefix
* `_query` - SQL to be stored into queue. Can valid SQL script

### Changelog
| Date | Author | JIRA | Description |
| ---------- | ----------- | ----- | ---------------------------------------------------------- |
| 2021-06-16 | @bartakm | | added check for provided query since it's called everywhere |
| 2019-12-09 | @kozusznikm | | initial version |

### Is unified: YES
DOCU*/
BEGIN
```
and screenshot how it looks like:
![image](https://user-images.githubusercontent.com/7868445/122214122-00e98c00-ceaa-11eb-8666-46ef3ced7bf7.png)

You can see the syntax highliting breaks in several places
* around 'q_' prefix causing next line to be not treated as comment anymore
* wrong syntax highliting stops at work "it;s" but single quote character is somehow significant, because removing it makes wrong highlighting continue...

Anyway I failed in attempts to find exact scenario what combination of characters leads to the issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.