dbader / dbader/schedule

[CRASH CONDITION] - Guard self.unit against None

Open
#646 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
12.3k
Forks
999
PR merge metrics
No merged PRs in 30d

Description

https://github.com/dbader/schedule/blob/82a43db1b938d8fdf60103bd41f329e06c8d3651/schedule/__init__.py#L305

- If `self.interval == 1` is _**True**_, and, `self.unit` is _**None**_ (which is what its being initialized to here) : https://github.com/dbader/schedule/blob/3863effe15ec8239ba88c65a4231a67e43b116df/schedule/__init__.py#L232
It results in crash.

- The code should guard against `self.unit` being **_None_** before attempting `self.unit[:-1]`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.