db-migrate / db-migrate/node-db-migrate

Replace `mkdirp` with `fs.mkdirSync(path, { recursive: true })`

Open
#835 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.3k
Forks
361
PR merge metrics
No merged PRs in 30d

Description

### Is your feature request related to a problem? Please describe.

The `mkdirp` utility is used in db-migrate https://github.com/search?q=repo%3Adb-migrate%2Fnode-db-migrate%20mkdirp&type=code

It can be replaced with Node.js native fs.mkdirSync added `recursive` option in Node.js [v10.12.0](https://github.com/nodejs/node/releases/tag/v10.12.0) published on Oct 10, 2018.

### Describe the solution you'd like
Replace `mkdirp` with `fs.mkdirSync(path, { recursive: true })`

### Additional context
The `mkdirp` currently uses these native APIs:
* https://github.com/isaacs/node-mkdirp/blob/fdf6005432c2506ce31f8cae237039dda2f8479d/src/opts-arg.ts#L4-L8
* https://github.com/isaacs/node-mkdirp/blob/fdf6005432c2506ce31f8cae237039dda2f8479d/src/mkdirp-native.ts#L13-L19

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.