db-migrate / db-migrate/node-db-migrate

setting DATABASE_URL doesn't ignore defaultEnv from .db-migraterc

Open
#564 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
2.3k
Forks
361
PR merge metrics
No merged PRs in 30d

Description

## I'm submitting a...

- [x] Bug report
- [ ] Feature request
- [ ] Question

## Current behavior
running `db-migrate` with `DATABASE_URL` defined does not ignore `defaultEnv` from `.db-migraterc`

## Expected behavior
running `db-migrate` with `DATABASE_URL` respects that value and doesn't try to read `defaultEnv` from `.db-migraterc`

## Minimal reproduction of the problem with instructions
1. `export DATABASE_URL=mysql://`
1. create a `.db-migraterc` with a `defaultEnv` configured. I chose local instead of dev for my example.
1. Run `db-migrate`.
1. You will see something like "environment 'local' is not defined"

## What is the motivation / use case for changing the behavior?
When setting database URL, the intent is that it is defining everything about your environment. To respect the `defaultEnv` setting from `.db-migraterc` seems to contradict that

## Environment



db-migrate version: 0.11.1
plugins with versions: unknown, don't think I'm using plugins?
db-migrate driver with versions:
mysql 1.1.10

Additional information:
- Node version: 8.9.4
- Platform: MacOS 10.13

Others:

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/57571332-setting-database_url-doesn-t-ignore-defaultenv-from-db-migraterc?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.