db-migrate / db-migrate/node-db-migrate

Add explicit support for UUIDs

Open
#532 4 comments 6 reactions 0 assignees View on GitHub
feature
Dominant language
JavaScript
Stars
2.3k
Forks
361
PR merge metrics
No merged PRs in 30d

Description

## I'm submitting a...



[ ] Bug report
[x] Feature request

## Current behavior

When I add a column with a type of `uuid`, I get the following warning:

```
[WARN] Using unknown data type UUID
```

## Expected behavior

I would expect no warning message as long as I have the `pgcrypto` extension installed.

## Minimal reproduction of the problem with instructions

Add a column with a type of `uuid`.

## What is the motivation / use case for changing the behavior?

Personally, I'm a fan of having no warnings in my project. I believe when warnings start piling up that aren't problems, developers begin to ignore them, which causes real issues to be missed. In this case, the `uuid` type is valid, but `db-migrate` doesn't recognize it.

## Environment

```
db-migrate version: 0.10.2
db-migrate-pg: 0.2.5
db-migrate-plugin-babel: 1.0.0

Additional information:
- Node version: 9.2
- Platform: Linux (via Docker)
```

Others:

I believe this issue originally surfaced in #34. I do think allowing pass-through column info is a good idea, but I don't feel like UUIDs should produce warnings.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/53444905-add-explicit-support-for-uuids?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.