db-migrate / db-migrate/node-db-migrate

getInstance with only string not working

Open
#469 5 comments 0 reactions 0 assignees View on GitHub
bug Refactoring
Dominant language
JavaScript
Stars
2.3k
Forks
361
PR merge metrics
No merged PRs in 30d

Description

According to the docs https://db-migrate.readthedocs.io/en/latest/API/programable/ this should work: `let dbmigrate = DBMigrate.getInstance(true, './path/to/database.json');`

Probably because here https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L104 never the type string is checked. Should I do a PR?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/43528208-getinstance-with-only-string-not-working?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.