For dropdown, the validation for choices is too strict if id-fn and label-fn are provided
Open
Nobody has claimed this yet.
bug
- Dominant language
- Clojure
- Stars
- 823
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
Currently, a single-dropdown requires the choices to be a vector-of-maps. But if a user specifies the id-fn and label-fn, then strictly speaking, each entry in that vector doesn't need to be a map.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the single-dropdown validation that requires a vector of maps, then inspect how id-fn and label-fn are used. Done means a dropdown can accept non-map entries when both functions are provided, while the existing validation remains appropriate otherwise; add regression coverage if the project has a nearby test for this component.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100