day8 / day8/re-com

Don't hardcode colors

Open
#33 0 comments 2 reactions 1 assignee View on GitHub

@MawiraIke is already working on this.

Since May 18, 2021.

enhancement styling
Dominant language
Clojure
Stars
823
Forks
142
No merged PRs in 30d

Description

For example: https://github.com/Day8/re-com/blob/master/src/re_com/modal_panel.cljs#L49 and https://github.com/Day8/re-com/blob/master/src/re_com/splits.cljs#L120

The components aren't compatible with bootstrap dark themes because of this.
IMO colors shouldn't be hardcoded. A possible middle ground could be to use classes.
(Re-com already needs its own CSS anyway.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.