Pass event to popover :on-cancel
Open
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 823
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
When the user clicks outside the popover to close it, the on-click event is propagated to the parents of the popover element. This causes an issue for me. It would be great if the :on-cancel function could receive the event so one can (.stopPropagation e) if one wishes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the popover component's :on-cancel callback and the outside-click handler described in the issue. Verify how the click event currently propagates, then confirm that the callback can receive it and that the requested behavior is covered by the relevant component checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100