day8 / day8/re-com

Simple-v-table should preform validation on the columns maps

Open
#259 0 comments 0 reactions 2 assignees View on GitHub

@Gregg8 is already working on this.

Since Mar 3, 2021.

Dominant language
Clojure
Stars
823
Forks
142
PR merge metrics
No merged PRs in 30d

Description

though the documentation says the following

one element for each column in the table. Must contain :id,:header-label,:row-label-fn,:width, and :height. 

None of these are actually required, but if you leave out :row-label-fn you will get the following uncaught error.

Cannot read property 'cljs$core$IFn$_invoke$arity$1' of null

Also I don't think :header-label should be required as we often have examples with empty headers, and I don't think we ever use :height`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.