Clicking on info-button should stopPropagation
Open
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 823
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
This is minor but I can't think of any case when the info-button should propagate the click event. Could you add (.stopPropagation event) on line 217 or so to info-button's handler-fn in buttons.cljs, thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open buttons.cljs and inspect the info-button handler-fn around line 217. Confirm how the click event is handled, then add the requested propagation stop and verify that clicking the info button no longer reaches its parent handler.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100