dawsbot / dawsbot/essential-eth

[TS] Allow `ReadonlyArray` everywhere we have `Array`

Open
#261 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
310
Forks
34
PR merge metrics
No merged PRs in 30d

Description

Currently there is an error if you want to pass in a `ReadonlyArray` to a `constructor` like "`new FallthroughProvider(bscRpcs)`". In these situations we should also allow readonly arrays. This does not change any JS, only TS

Also find any other relevant places in the codebase this would be an issue for library consumers

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.