davidtheclark / davidtheclark/react-aria-menubutton

Spacebar bug in Firefox

Open
#107 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
452
Forks
76
PR merge metrics
No merged PRs in 30d

Description

In the [demo](https://davidtheclark.github.io/react-aria-menubutton/demo/), there seems to be a bug when using spacebar to trigger the menu.

### Steps to reproduce:
1. tab to focus the menu trigger "Select a word"
2. spacebar to open menu
3. while the menu is opened and focused, spacebar to close.

**Expected result:** menu closes

**Actual result:** menu closes and opens in succession.

**Tested on:**
- Firefox 60.9.0 (Mac)
- Firefox 45.9.5 (Mac)
- _may affect other Firefox (Mac) versions as well._

### Other Notes

If you change the `Button.tag` to `span`, this works correctly. However, it should be expected that this should work with `button`. An old issue (#76) stated that the `tag` is exposed only for stylistic changes. However, with this bug, it becomes invalid due to this browser quirk.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.