davidmoten / davidmoten/rxjava-jdbc
With AutoCommit to false, connection are not closed
- Dominant language
- Java
- Stars
- 801
- Forks
- 114
- Avg merge
- 1m
- Merged PRs (30d)
- 3
Description
The connections are not being closed when the autoCommit is set to false.
Is there a reason why we have this call `Util.closeQuietlyIfAutoCommit(state.con);` in a `QuerySelectOnSubscribe` ?
``` java
private static void closeQuietly(State state) {
// ensure only closed once and avoid race conditions
if (state.closed.compareAndSet(false, true)) {
// set the state fields to null after closing for garbage
// collection purposes
log.debug("closing rs");
Util.closeQuietly(state.rs);
log.debug("closing ps");
Util.closeQuietly(state.ps);
log.debug("closing con");
Util.closeQuietlyIfAutoCommit(state.con);
log.debug("closed");
}
}
```
the problem with this config, is im getting a lot of active connections in my pool, and i end up with Connection is not available, request timed out after 30001ms.
And may i suggest to log the result of the operations too in debug.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.